FlowCharting 1.0.0 (old 0.9.1) in progress

algenty commented 3 years ago

Hi dear users, I need your feedback for the next version of Flowcharting :

[0.9.1b SNAPSHOT] - 2020-11-08

Added

New initialization engine for drawio libs
New notifier handler in panel.
Change default url draw.io by https://embed.diagrams.net
New edit design for grafana v7 (See example)
Add shape name and properties in inspect console (See example)
Add gaugePos property in Event Mapping for the gauge draw.io models See example)

Fixed

Fixed : Inspect mode (issue #209) (See example)
Fixed : Label position in shape (issue #147)
Fixed : Initialization of first model
Fixed : Display refresh between "edit mode" and "dashboard mode" in grafana v7 (issue #205)
Fixed : zoom on text without witdth and height
Fixed : Disable select text when double click for zoom
Fixed : retro compatibility with grafana 6.x (issue #218)
Fixed : Zoom when with 2 or mode panels with flowcharting (issue #214)

rulesv7_ani

inspectv7_ani

gaugePos_ani

Download it at https://algenty.github.io/flowcharting-repository/ARCHIVES.html

BR, Arnaud

bijwaard commented 3 years ago

Hi Arnaud,

Great work! New edit design works fine, good to see some more shape detail in inspector. Curious what the Lvl column in the expector is for.

I found some minor issues in 0.9.1b snapshot (tried using firefox and chromium-browser in Linux with grafana 7.2.2):

when editing the drawing, I still get warning about app.diagram.net
as reported before in edit mode need to fit/fill/exact or enlarge diagram area to see diagram

Kind regards, Dennis

algenty commented 3 years ago

Hi Dennis,

Thx for your feedback, if it is an existing panel, you need to change url in flowcharting section by https://embed.diagrams.net. If you're adding a new panel, url has the good value.

bijwaard commented 3 years ago

Hi Arnaud, Yes, that works, thanks.

Note that when no URL is filled in, it will open a browser with grafana main window....

bijwaard commented 3 years ago

Hi Arnaud, all, I'll be showing our flowcharting and other dashboards as part of the advanced measurement solution in a webinar next week. Kind regards, Dennis

xkilian commented 3 years ago

Sorry Arnaud, I have no feedback for you at this time, I am not running any Grafana 7.x yet. I was waiting for legacy panels to be converted and all our plugins to be upgraded to be compatible with Grafana 7. The only outstanding issue is worldmap map and alexandra map panels cannot be both installed and used in different dashboards. An odd bug. Keep up the excellent work.

algenty commented 3 years ago

hi @xkilian This version works with v6 off course

xkilian commented 3 years ago

Ah, I stand corrected, I will give it a try.

bijwaard commented 3 years ago

Hi Arnaud,

I found a bug in v[0.9.1] - 2020-07-04 regarding the threshold section for mapping rules. I've noticed that sometimes only 1 or 2 of the 3 metrics (there should be L1, L2, L3 values for power P) are appended with the label/text mappings (append new line), and I could temporarily work around this by disabling the threshold invert on a number of mapping rules. I used the inspect function to show the metric values, and they were present when this happened.

I can try to test with the newest 0.9.1 snapshot after our webinar this afternoon.

Kind regards, Dennis

bijwaard commented 3 years ago

Hi Arnaud, I just installed 0.9.1b snapshot in the substation and reverted my work-around. I can reproduce the issue above. Note that it happens mostly with selected influxdb datasource F0. I have not seen it with other selected fields F1..F8 yet. I added the inspect window to show that the metrics are available. I'm also showing the metric definition for Power (P) and its metric usage in the mapping.

The webinar was a success yesterday, the replay is now available online. The presentation gives more insight in our measurement solution, I guess the live demo is most interesting for grafana/flowcharting users, and shows powerful capabilities of a number of panels and data sources.

The demo starts using alexandra-trackmap to show the location of the measured substations using their GPS coordinates
next the flowcharting panel is used for the substation overview and feeder diagrams
next graph, plotly and SVG panels are used to display phasors, realtime signal and harmonics.
next the flowcharting panel is used to show the DSP flow within/between sensors, and realtime output signals in tooltips.
next the commandline usage of measurements and developing DSPs using measurements via an encrypted tunnel is demonstrated

We use the influxdb datasource for point 2,3 above and the simpod-json datasource for the realtime data (snapshots) in point 3 and 4. Point 1 for now uses the testdata db as datasource.

Kind regards, Dennis

algenty commented 3 years ago

Hi Dennis, Congratulation for your webinar ! For the bug, il don't understand. have you the same pb in 0.9.0 ? it's a regression ?

bijwaard commented 3 years ago

Hi Arnaud, Thanks. I have not tried 0.9.0. Thusfar, I tried 2 snapshots of 0.9.1, the newest one (0.9.1b) and an older snapshot from july.

algenty commented 3 years ago

@Dennis,

I'am watching your webinar, and at 22:30 and for history, i suggest to activate graphover on your dashboard to change color on flowcharting panel too (Ctrl+o). i return to the video ...

PS : Can i share the webinar on twitter ?

bijwaard commented 3 years ago

Hi Arnaud, You can of course share the webinar on twitter, the more publicity the better;-) I tried with the graphover, didn't know this feature, and now my issue now changes to 1, 2, and three values whenever I hover between graph panel and flowcharting panel, see movie below. I now also see the same for rms (current) in the Feeder. vokoscreen-2020-11-19_14-00-15.mkv.zip Forgot to capture the power graph with (bottom right), but it doesn't show obvious holes in the graphs.

Kind regards, Dennis

dennis commented 3 years ago

@algenty Keep in mind, you might trigger an notification when you do @[username]

xkilian commented 3 years ago

I am finally doing a test run this week on flowcharting beta with Grafana 6.7, do you have a newer version to test or is it still pertinent to test the current beta?

xkilian commented 3 years ago

All my dashboards are functional. Suggestions:

Documentation: When attaching multiple rules to the same object, links should be handled at the draw.io layer and not in the plugin, because then you need to add the link to all rules that relate to the object, otherwise depending on which rule is the active on, the link may not be available. I use this to show metrics and coloring based of Prometheus ALERTS metrics states on top of a simple metric show availability (like a ping metric).
Thank you for the coloring change on edit button. :-)
Having learned to use label_replace function of PromQ, to reduce the number of caracters in my legends they now fit in popup graph legends without wrapping.
The editing interface, with 200 hundred rules defined loads about as quick as the old version. Nothing noticeable in any case. But once loaded, it is very responsive and I like the new rule liste UI, it is more compact, no need click from right to left everytime you need to clone and edit.. 👍

I will proceed to testing the shared crosshairs with my metrics and changes based on state or metrics. Thank you for your work.

algenty commented 3 years ago

thx @xkilian and @bijwaard for you feedback I rename 0.9.1 with 1.0.0. For this version, a big work on UX Design and prepartion for multi diagram.

[1.0.0a SNAPSHOT] - 2020-12-06

TODO

Disable anim not work
message console size
display zoom percent
align icons
Column resize
Size of plugin

Added

New initialization engine for drawio libs
New draw.io libs (13.10.9)
New notifier handler in panel.
Change default url draw.io with https://embed.diagrams.net
New edit design for grafana v7 (See example)
New UX design and new concept "fast edit" :
- Can edit without expand rules and flowcharts with icons
- Advanced/detail mode on expand.
Add shape name and properties in inspect console (See example)
Add gaugePos property in Event Mapping for the gauge draw.io models See example)
Plugin is signed
Add Light theme support
New thresholds on dates (accept units like d, w, m, y, h, s or a date)
Can Enable/Disable each element.
Colors (threshold and background) can be empty.

Fixed

Fixed : Inspect mode (issue #209) (See example)
Fixed : Label position in shape (issue #147)
Fixed : Initialization of first model
Fixed : Display refresh between "edit mode" and "dashboard mode" in grafana v7 (issue #205)
Fixed : zoom on text without witdth and height
Fixed : Disable select text when double click for zoom
Fixed : retro compatibility with grafana 6.x (issue #218)
Fixed : Zoom with 2 or more FlowCharting (issue #214)
Fixed : Background color edition in flowchart tab

design_7_2

Now, the plugin is signed

Still some bugs like column resize or format message in console.

bijwaard commented 3 years ago

Hi Arnaud,

Great work, you have been busy! I would like to test it, but the download does not seem to work for me. Moreover, the new 1.0.0a snapshot does not (yet) show up in the archive list and changelog.

Kind regards, Dennis

algenty commented 3 years ago

pushed, try again

bijwaard commented 3 years ago

Great, thanks!

bijwaard commented 3 years ago

Hi Arnaud,

Here is my first feedback for 1.0.0a:

nice that you can now do basic operations on the collapsed rules and inspect items
maybe you can make the different mapping categories/types collapsible as well, since rules are often longer than a page
I notices the button "Reduce the rule" at the bottom of an expanded rule, you may want to rename it to "Collapse" and change its tooltip from "Refresh/apply" to something else.
in the inspect, the labels do not expand the placeholders, this could also be done through a tooltip like is done for the shapes
still not sure what the Lvl column is for in the inspector
some performance tweaks may be required to speed up Panel Edit, uncollapse list of mapping Rules, etc.

Kind regards, Dennis

algenty commented 3 years ago

ok, thx @bijwaard for this feedback

xkilian commented 3 years ago

Are dashboard variables supported, so that we can make a generic dashboard? (if the layout is always the same and the object ids remain consistent, or could be named to match a variable) We have lots of recurring system patterns that could modeled in flowcharting.

Even in rules, when cloning rules I often find myself changing always the same key in the rule name, metric filter and URL and the only unique thing is the mapping to the object. Definately need to find some way to have rules autogenerated based on template variables and pre-defined object IDs that could match the same variable name. This would make my 200 rules be generated in two template rules. I think you are not far from being able to do this.

Great job, I will run off and test this new version and hopefully have some intelligent feedback. :-)

algenty commented 3 years ago

Hi my best beta users @xkilian, @bijwaard and @CrashLaker. In this beta, i introduce to you the concept of "fast edit" : Change metric name and targets very fast with only one button. Create your rule model, duplicate it and change targets and metric name.

fastedit_ani

[1.0.0b SNAPSHOT] - 2020-12-08

TODO

Disable anim not work
display zoom percent
align icons
Size of plugin
Styles on firefox

Added

New initialization engine for drawio libs
New draw.io libs (13.10.9)
New notifier handler in panel.
Change default url draw.io with https://embed.diagrams.net
New edit design for grafana v7 (See example)
New UX design and new concept "fast edit" :
- Can edit without expand rules and flowcharts with icons
- Advanced/detail mode on expand.
- Fast edit mode
Add shape name and properties in inspect console (See example)
Add gaugePos property in Event Mapping for the gauge draw.io models See example)
Plugin is signed
Add Light theme support
New thresholds type : dates (accept units like d, w, m, y, h, s or a date)
New event mapping operators
Can Enable/Disable each element.
Colors (threshold and background) can be empty.

BR Arnaud

xkilian commented 3 years ago

Woah! Very very nice, that will be a great time saver in the current configuration method! Did you figure out how to fix the colomn sizing in the rule editor for grafana 6.x users? I think you hinted that this was a problem. Anyway, I guess I will see tomorrow how it looks. Once again, great work!

bijwaard commented 3 years ago

Hi Arnaud,

Great work, some remarks:

when I fast-edit the rule metric, the old value (e.g. a regular expression) disappears. It would be great if we can edit/copy it in fast edit mode.
is the Lvl column in the inspector related to the threshold levels? If so, I suggest to change tooltip to "Current threshold level"
thanks for changing "Reduce the rule" to "Collapse", the tooltip "Refresh/Apply" on this button is still the same
thanks for handling placeholders in inspector labels

Kind regards, Dennis

cbtsgithub commented 3 years ago

Hi Arnaud, I'm a very fan of your work since the beginning. Your plugin is outstanting. Is it possible to send you a mail on any @ ? Chris

algenty commented 3 years ago

Hi @cbtsgithub My email is available at the end of readme

Schrolli91 commented 3 years ago

I have found, that the usage of Grafana Transformations will break the plugin. As soon as i add a "Field from calculation" transformation, all my values are empty-

If I remove the transformation again, all seems to work correctly.

[tested with 1.0.0b from 2020-12-08]

bijwaard commented 3 years ago

Dear all,

We just got a Grafana blog post published mentioning flowcharting as the most useful plugin;-)

Kind regards, Dennis

algenty commented 3 years ago

Hi Dennis, Thansks a lot for the link 😁

Le mer. 6 janv. 2021 à 20:29, Dennis notifications@github.com a écrit :

Dear all,

We just got a Grafana blog post https://grafana.com/blog/2021/01/06/how-using-grafana-and-plugins-gave-a-jolt-to-smart-state-technology-a-company-advancing-technology-for-energy-infrastructures/ published mentioning flowcharting as the most useful plugin;-)

Kind regards, Dennis

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/algenty/grafana-flowcharting/issues/242#issuecomment-755562057, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGVW5PFR4YNZUOUT2MSGHTSYS2ZLANCNFSM4TOTYPMA .

-- Arnaud GENTY Responsable et Ingénieur de production IT (SAP/J2EE). Tel : (+33)6.23.08.30.14 Email : arnaud.genty@gmail.com

meshkov commented 3 years ago

I have periodically problem with A/Time, but i did not use a Transformations. Data arrives correctly:

Found solution for my problem. Enable "Disable data aligment" only on first Query A of 4: I don't understand why all the rules work, A/Time disappears if I set it only for the first query. whithout "Disable data aligment": Environment: Grafana v7.4.0 Zabbix data source FlowCharting 1.0.0b

xkilian commented 3 years ago

Ok, thank you for the great work Arnaud. Not may bug fixes to raise, my principal comment is for thresholds. Namely having the same threhold logic as Grafana which adds a Base colour. The base colour would add a default colour if there is no data. At this point it might be too much of a breaking change. Efficiency in loading large rule sets. More caracters for text in tooltips: Maybe 5-10 more caracters wide for the tooltip area so that longer text does not wrap. Everything else is more of a feature wish list. Streaming, layers, sparkline graphs, bug fixes already raised by @bijwaard

Jii-Hoo commented 3 years ago

I have been trying 1.0.0b and so far it has been working nicely. However, as I have quite huge number of queries and rules (one big diagram), one practical issue came up. I'm basically copying same set of rules (7-10 rules in set) again and again for various services. But whenever I copy a rule, the copy is placed before the original in the list. So it would be nice to have an option to place the copy always to the end of list of rules, thus keeping them in order when multiple copies are done.

Of course, better option would be to be able to deal with this by using less rules. For me the previously proposed way to map queries based on diagram's attributes would be the best option.

kenizhou commented 3 years ago

Thanks for your great works!

x70b1 commented 3 years ago

Is it still an issue that we can't replace google fonts with dynamic text (https://github.com/algenty/grafana-flowcharting/issues/203)? Sorry, I can't test this at the moment. A solution would be awesome!

nmbath commented 3 years ago

I am running FlowCharting 1.0.0(a), a great plugin and will be very handy.

I have run into a problem. When my InfluxDB returns no data, the label from the digram is displayed. Is there anyway to not display the label. It seems a little like a bug from https://github.com/algenty/grafana-flowcharting/issues/65, which was fixed.

Any guidance?

RedShift1 commented 3 years ago

@nmbath I won't be able to help you with your issue but I like how your diagram looks. Would you mind sharing a screenshot of the entire thing?

bijwaard commented 3 years ago

Hi nmbath,

I have run into a problem. When my InfluxDB returns no data, the label from the digram is displayed. Is there anyway to not display the label. It seems a little like a bug from #65, which was fixed.

I assume you use a text mapping rule to replace the contents of the label. You can try to make the label empty (or some spaces) in your draw.io diagram.

Kind regards, Dennis

nmbath commented 3 years ago

@bijwaard Thank you or the idea, that worked.

neshorg commented 3 years ago

Hello Everyone!

Is anyone using the 8.1.3 OSS version? I'm experiencing that this plugin version [1.0.0b] "prevents" you from accessing the plugin page through the menus "Configuration>plugins" and "Server Admin>plugins" with the following error:

Other than that, everything seems to be working fine while being used on dashboards. The plugin page seems to be the only problem, probably due to accessing other checks/validations. I'm considering to revert back to 8.1.1 for the time being which still works fine with 1.0.0b.

bijwaard commented 3 years ago

Hi neshorg, Thanks for trying the new grafana release, I just gave it a spin myself. I cannot reproduce your error via Configuration/plugins, and don't have the ServerAdmin/plugins menu item. The build-in shapes are back in my dashboards, and it seems to solve tickets #313, #314, and hopefully #312. Here is the relevant blank shape fix in the grafana changelog

Plugins: Track signed files + add warn log for plugin assets which are not signed. #38938

Kind regards, Dennis

neshorg commented 3 years ago

Hello Dennis,

Thanks for replying and testing! I've since then gone back to 8.1.1 and strangely still got the same error with 1.0.0b (even though this worked nicely with 8.1.1 in the past). So the upgrade to 8.1.3 might've broken more stuff than my backed-up grafana.db can "restore". I even tested 1.0.0a on 8.1.1 and still got the same error. So for now I was forced to go all the way back to 0.9.1 which does work.

Other thing I can think of is that I'm running this grafana instance on a windows VPS...not sure if this has anything to do with my specific error during grafana upgrade/downgrade compared to a different OS environment.

Lastly, I can't remember ever having trouble with built-in shapes or anything related to shapes. The only thing that comes to mind is not being able to choose a different threshold value in the "when" column under Event/Animation Mappings of a rule. I always seem to only get the "All" option while definitely having different thresholds configured which should be recognized in this stage.

raphaelrrl commented 3 years ago

Hi guys, I've been testing flowcharting and the new improvements are perfect. your work is amazing @algenty , thanks for sharing.

Teofaness commented 2 years ago

Hello guys! I have the problem using the zabbix problems data source. When selecting apply metric , it returns with repeated values, as shown in the image:

bijwaard commented 2 years ago

With influx/ql and some other data sources, you can use aliases for metics using tags and template variables, does zabbix have something like that? What else can you "show" besides "problems"?

isaqueprofeta commented 2 years ago

Hello guys! I have the problem using the zabbix problems data source. When selecting apply metric , it returns with repeated values, as shown in the image:

It's repeated because you have two queries. And this two queries aren't merged from the datasource to the front-end processing, then you have two "Problems" : one from the query A and another from query B.

cardosocristian commented 2 years ago

Is it possible to support Grafana 9?

algenty commented 2 years ago

Yes, but i need to migrate to react first

BR Arnaud

Le ven. 15 juil. 2022 à 21:08, Cristian Cardoso @.***> a écrit :

Is it possible to support Grafana 9?

— Reply to this email directly, view it on GitHub https://github.com/algenty/grafana-flowcharting/issues/242#issuecomment-1185828562, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGVW5NBRVYMHKLXL22M6GDVUGZKFANCNFSM4TOTYPMA . You are receiving this because you were mentioned.Message ID: @.***>

-- Arnaud GENTY Responsable et Ingénieur de production IT (SAP/J2EE). Tel : (+33)6.23.08.30.14 Email : @.***

iamelec commented 2 years ago

Is it possible to add support for opening links in current tab when adding a link mapping within the flowcharting plugin in Grafana? Right now it opens in a different tab, which gives problems when embedding my dashboard in a iframe within a different program (as I can only navigate by using links which open in current tab).

algenty / grafana-flowcharting