search

algenty / grafana-flowcharting

Flowcharting, plugin for Grafana to create complexe visio's draws style like technical architectures, floorplan, diagrams, hierarchical schema based on draw.io
Apache License 2.0
981 stars 149 forks source link

Rack / HPE Aruba shape category shows white box #312

Open Sourve opened 3 years ago

Sourve commented 3 years ago

The HPE Aruba categories (Gateways, Security, and Switches) for shapes show up as white boxes when leaving the editor. Is there a place in the files to add these categories as I am assuming they were added since the last update.

bijwaard commented 3 years ago

This looks related to #313 and #314. Are you by any change using grafana 8.1.2?

MuhdMurad commented 3 years ago

This looks related to #313 and #314. Are you by any change using grafana 8.1.2?

313 -- yes i am using grafana 8.1.2 version

Sourve commented 3 years ago

No, it is version 8.1.1 Enterprise Free.

MuhdMurad commented 3 years ago

means this issue happen on 8.1.2 also 8.1.1. i am using 8.1.2 version and facing the same issue.

bijwaard commented 3 years ago

Hi Sourve, This may be another issue, since the extension-based file check was introduced in grafana 8.1.2, I see these HPE shapes in the flowcharting 1.0.1b snapshot with the right access rights, which version of the flowcharting plugin are you using? If I'm not mistaken, the extension-based file check was introduced to replace a check based on file permission, the executable bit should not be set (sudo chmod uog-x var/lib/grafana/plugins/grafana-flowcharting/dist/libs/drawio/stencils/rack/rack/hpe_aruba/*.xml).

$ ls -lsa /var/lib/grafana/plugins/grafana-flowcharting/dist/libs/drawio/stencils/rack/rack/hpe_aruba
total 4132
   4 drwxr-xr-x 2 grafana grafana    4096 Dec  6  2020 .
   4 drwxr-xr-x 3 grafana grafana    4096 Dec  6  2020 ..
 308 -rw-r--r-- 1 grafana grafana  313881 Dec  8  2020 gateways_controllers.xml
  96 -rw-r--r-- 1 grafana grafana   97778 Dec  8  2020 security.xml
3720 -rw-r--r-- 1 grafana grafana 3807659 Dec  8  2020 switches.xml

Kind regards, Dennis

Sourve commented 3 years ago

I am using 1.0.0b snapshot, I did not see a 1.0.1b in the archives. When I run the list it shows that the folder exists with the difference being that root is in place of grafana user and group. Is this due to how I installed the plugin that may be causing this problem?

$ sudo ls -lsa /var/lib/grafana/plugins/grafana-flowcharting/dist/libs/drawio/stencils/rack/rack/hpe_aruba total 4132 4 drwxr-xr-x 2 root root 4096 Dec 6 2020 . 4 drwxr-xr-x 3 root root 4096 Dec 6 2020 .. 308 -rw-r--r-- 1 root root 313881 Dec 8 2020 gateways_controllers.xml 96 -rw-r--r-- 1 root root 97778 Dec 8 2020 security.xml 3720 -rw-r--r-- 1 root root 3807659 Dec 8 2020 switches.xml

bijwaard commented 3 years ago

Hi Sourve, The executable bits are not there on the *.xml files, so that looks ok. I don't expect that the root user/group will have much difference since the files are readable for others, but there may be a directory in the path for which that is different, you could of course change the user&group for the whole plugin and see if that solves your problem: sudo chown -R grafana:grafana /var/lib/grafana/plugins/grafana-flowcharting/ Kind regards, Dennis

Sourve commented 3 years ago

Couldn't figure anything out. Did find out that Rack/IBM also has this issue but everything else in the rack directory shows up fine. They seem to match other xml files in the same directory as them so I can't find a cause. Thanks for the suggestions though.

bijwaard commented 3 years ago

I am using 1.0.0b snapshot, I did not see a 1.0.1b in the archives.

My bad, I mistyped, I'm also using v1.0.0b Dennis

bijwaard commented 3 years ago

There may be some inconsistency in the shape names (first line of the xml files) versus folder names, maybe that is why they are not found. E.g. in rack/ibm.xml it has name=mxgraph.ibm, and others like rack.hp show mxgraph.rack.hp. rack/rack/hpe_aruba/gateway_controllers.xml has name=mxgraph.rack.hpe_aruba.gateways_controllers. I.e. a 'rack' sub-path is missing in those path names.

Sourve commented 3 years ago

Might be, I have no solution for it and can't edit the files or it will become a manipulated signature and wont load. I'm guessing the same will happen if I try to move the files directory.

bijwaard commented 3 years ago

You may be right, a new plugin version may need to be created, the drawio shapes may have been fixed upstream. Until now only Arnoud has provided those, but he has not been active lately, I don't have so much experience with this (I'm more experienced in c++, python, golang, etc.). Kind regards, Dennis