search

algesten / str0m

A synchronous sans I/O WebRTC implementation in Rust.
MIT License
280 stars 45 forks source link

io/stun: Expose `split_username` publicly #505

Closed lexnv closed 2 months ago

lexnv commented 2 months ago

In litep2p we are using the low-level ice module to handle connections.

We'd need the to split the username attribute from a StunMessage object to instantiate an rtc client.

This is the missing functionality that currently blocks our migration from 0.4.1 to 0.5 (which includes a needed fix for us: https://github.com/algesten/str0m/commit/7ed5143381cf095f7074689cc254b8c9e50d25c5).

Would love to hear your thoughts on this, and if you think another approach would be more appropriate, thanks! 🙏

lexnv commented 2 months ago

@algesten Thanks a lot for the swift reply! 🙏

Would it be possible to have this included in a point release / your next release window? Thanks

algesten commented 2 months ago

Yeah, sure. I can make a point release now.

lexnv commented 2 months ago

Amazing! Thanks again!

algesten commented 2 months ago

@lexnv that should be published now.