Update nack/twcc register after SRTP decrypt

algesten / str0m

A synchronous sans I/O WebRTC implementation in Rust.

MIT License

280 stars 45 forks source link

Update nack/twcc register after SRTP decrypt #528

Closed algesten closed 4 weeks ago

algesten commented 1 month ago

Currently we update the TWCC and Nack registers even if we don't manage to decrypt the SRTP and/or remove the padding. This means a corrupted UDP packet might still count as successful wrt to resends and bwe.

pthatcher commented 4 weeks ago

I think this looks good. We shouldn't do anything with a packet if SRTP decrypt fails.

algesten commented 4 weeks ago

Cool. Thanks. I'll merge!