Fix tests for rustc 1.82-beta

algesten / str0m

A Sans I/O WebRTC implementation in Rust.

MIT License

334 stars 50 forks source link

Fix tests for rustc 1.82-beta #561

Closed algesten closed 2 months ago

algesten commented 2 months ago

rustc 1.82-beta in this commit changes something about how hashes are calculated (likely this PR). Since our tests have pinned hash values, we get a breakage.

Since we uphold MSRV 1.65, we can't pin the hash in the test since we will get broken CI tests when we ensure the MSRV compiles.

algesten commented 2 months ago

Could we chop it down to not be super long and still preserve enough entropy?

thomaseizinger commented 2 months ago

We also depend on crc which allows for a 16-byte output. That allows us to stay within the 32 char limit of foundation. Could use that?

algesten commented 2 months ago

Let's merge this and open a new PR exploring a stable hash.