search

algesten / str0m

A Sans I/O WebRTC implementation in Rust.
MIT License
334 stars 50 forks source link

Move openssl vendored featureflag to default #580

Closed xnorpx closed 4 weeks ago

xnorpx commented 1 month ago

Some security requirements might be that a user must use system provided OpenSSL.

Added a new feature called openssl-vendored which uses openssl feature and also add the vendored flag.

Easy way to test if open ssl is vendored or not is to.

cargo tree | grep openssl-src -> vendored

changed default to be openssl-vendored to ensure no functionality change

xnorpx commented 1 month ago

No still needs some work

xnorpx commented 1 month ago

This is ready for review

xnorpx commented 4 weeks ago

As it happens, someone just now submitted a PR to ureq that shows a slightly more elegant way of doing this.

algesten/ureq#866

We can have a vendored feature flag that applies to openssl if it is enabled. See the ? syntax. I think that looks nicer.

Indeed, will try it out tonight to make sure it does what I think it does.

xnorpx commented 4 weeks ago

@algesten ok ready for review, tested all combinations