algirdasc / expensave

Personal and family expense tracking and budgeting application, enabling better financial management
GNU General Public License v3.0
2 stars 1 forks source link

bug: removed timezone from dates #58

Closed algirdasc closed 5 months ago

algirdasc commented 5 months ago

fixes #55

Summary by CodeRabbit

algirdasc commented 5 months ago

@coderabbitai review

coderabbitai[bot] commented 5 months ago
Actions Performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot] commented 5 months ago

[!IMPORTANT]

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes address timezone consistency issues and enhance the frontend's version management. Key modifications include setting the default timezone to 'UTC' in backend configurations and kernel, adding date-handling interceptors in the frontend, and integrating version information dynamically from package.json. These updates ensure consistent date formatting across the application and provide clear version visibility in the frontend.

Changes

Files/Paths Change Summaries
Dockerfile Uncommented npm run analyze command to enable it during Docker build process.
backend/config/packages/doctrine.yaml Updated time_zone setting in Doctrine configuration to 'UTC'.
backend/config/services.yaml Added configuration for DateTimeNormalizer specifying default datetime format.
backend/src/Kernel.php Modified boot() method to set default timezone to 'UTC'.
backend/src/Service/Statement/Import/Resolver/StatementImportResolver.php Marked StatementImportResolver class as readonly.
frontend/package.json Removed version and postversion scripts.
frontend/src/app/app.component.ts Added import for NbDateService and modified constructor to include it.
frontend/src/app/app.module.ts Added DateInterceptor to handle date-related functionality in HTTP interceptors.
frontend/src/app/interceptors/date.interceptor.ts Added DateInterceptor class to shift dates in request body using DatePipe.
frontend/src/app/modules/auth/components/login/login.component.html Added section to display application version.
frontend/src/app/modules/auth/components/login/login.component.ts Added import for environment and declared protected readonly environment = environment.
frontend/src/app/modules/main/dialogs/expense-dialog/expense-dialog.component.html Added nb-list-item element to display expense.createdAt.
frontend/src/app/modules/main/main.component.ts Changed date parsing logic to directly create a new Date object.
frontend/src/app/util/date.util.ts Added static readonly property DATE_TIME_FORMAT to DateUtil class.
frontend/src/environments/environment.interface.ts Added version field to EnvironmentInterface.
frontend/src/environments/environment.prod.ts Imported package.json and assigned version property from it.
frontend/src/environments/environment.ts Imported package.json and assigned version property from it.
frontend/tsconfig.app.json Restructured compilerOptions, and added specific paths to include/exclude TypeScript files.
frontend/tsconfig.json Added allowSyntheticDefaultImports, resolveJsonModule, and useDefineForClassFields options.

Assessment against linked issues

Objective (Issue #55) Addressed Explanation
Ensure timezone consistency to prevent shuffling of expenses in calendar when browser timezone changes
Set default timezone to 'UTC' in backend configurations and kernel
Add date-handling interceptors in the frontend to manage date formats
Display application version in the frontend login component

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.