algo26-matthias / idna-convert

Pure PHP IDNA Converter
http://idnaconv.net
GNU Lesser General Public License v2.1
66 stars 23 forks source link

Question about B/C #14

Closed infograf768 closed 5 years ago

infograf768 commented 5 years ago

We use idna convert for Joomla. Is this library B/C with the former mso one?

glensc commented 5 years ago

@infograf768 you should have created two way backlink, i.e link to the origin issue as well: https://github.com/joomla/joomla-cms/pull/24009

however, if packagist picks up changes from this repository to old packagist name, then there's semver compatibility issue, and next version in the new repo should be 2.x, not 1.x cc @algo26-matthias

otherwise the compatibility should be fine:

glensc commented 5 years ago

i think if the token is different (or removed) then the mso/idna-convert should not get any more updates.

so, as the master branches are different, the old packagist package does not seem to get updates.

cc @algo26-matthias

glensc commented 5 years ago

cc @algo26-matthias

algo26-matthias commented 5 years ago

@glensc Thanks for mentioning me. To end confusion about the package I tagged the latest commit as being v2.0.1. HTH!