Change {} to [] for string offset access

algo26-matthias / idna-convert

Pure PHP IDNA Converter

http://idnaconv.net

GNU Lesser General Public License v2.1

66 stars 23 forks source link

Change {} to [] for string offset access #22

Closed Hackwar closed 5 years ago

Hackwar commented 5 years ago

PHP 7.4 and 8.0 have deprecated the use of curly braces for string offset access (so $string{$i} is wrong, $string[$i]is supposed to be right.) and this change makes our (the https://github.com/joomla/joomla-cms project) CI fail on the code in idna-convert. I would be very gratefull if you could accept this PR and do a new release to make our CI pass again for 7.4 and 8.0. 😄

Thanks for your work on this library.

glensc commented 5 years ago

it seemed always wrong to me to use {} for string access

algo26-matthias commented 5 years ago

Thanks for the PR. This outdated syntax surely has to go!