search

algobasket / PeatioCryptoExchange

An open-source Crypto-Currency exchange. Peatio v3.0 Coming Soon !
https://www.peatio.info
186 stars 202 forks source link

Bug Bounty #75

Open altcoin-services opened 5 years ago

altcoin-services commented 5 years ago

Hello, i opened a issue a few days ago and the repo owner sent me an id who didn't know how to add cryptonote coins, so im opening this one to get some helps. wallet rpc is already done by graviex : https://github.com/InfraexDev/peatio/pull/106/files i'm looking for a ruby dev to adapt app/models/currency.rb to work with cryptonote too. (or any other part of this source) and i will donate a reasonable donation. reply if any your'e interested, thanks.

TTcoinDeveloper commented 5 years ago

So u need some1 to test it 4 u?

altcoin-services commented 5 years ago

@TTcoinDeveloper already tested , I'm getting some errors on coin RPC wallet I think currency.rb needs to be changed

TTcoinDeveloper commented 5 years ago

What are your configs?

altcoin-services commented 5 years ago

@TTcoinDeveloper what coin I wanted to be implemented for you mean? Karbo (KRB)

TTcoinDeveloper commented 5 years ago

Run your ./coind getinfo make sure there r no wallet errors and i nput the correct rpc username and password ip cud be 0.0.0.0 instead of localhost and the rpc port of the coind u r using

TTcoinDeveloper commented 5 years ago

Make sure the coin rpc at /home/user/.coin/coin.conf matches the currency.rb

altcoin-services commented 5 years ago

@TTcoinDeveloper coin daemon and walletd are ok , but walletd gives me requested url / is not found when I'm trying to run daemons on peatio I don't know if you already know about Cryptonote RPC methods

altcoin-services commented 5 years ago

@TTcoinDeveloper what do you mean by "coin rpc at /home/user/.coin/coin.conf matches the currency.rb" ?

TTcoinDeveloper commented 5 years ago

The logins the password rpcallowip=0.0.0.0 rpcport=×××× listen=1 server=1 make sure u put the exact infos on the currency.rb to open the rpc port to peatio

altcoin-services commented 5 years ago

@TTcoinDeveloper oh , I forgot about it , I will test and share the results thanks.

TTcoinDeveloper commented 5 years ago

image

TTcoinDeveloper commented 5 years ago

it is a bit different but it is generally the same as any coind just the rpcallowip= will be seed-node the the rpcport= will be rpc-bind-port=

altcoin-services commented 5 years ago

@TTcoinDeveloper ok I will try and share the results thanks.

altcoin-services commented 5 years ago

@algobasket do you had a open issue phobia?! It's not resolved why do you close it?!

altcoin-services commented 5 years ago

@algobasket thanks for reopening thread , so many peoples are looking forward to this.

TTcoinDeveloper commented 5 years ago

So if the issue is not resolved what seems to Be the error?

altcoin-services commented 5 years ago

@TTcoinDeveloper it has nothing to do with config file , on Cryptonote you should set these parameters on terminal not on a configuration file, and the screenshot you sent is just a fork note config file, at the moment the error it returns is that it doesn't recognize safe_getbalance on currency.rb , if I change this to getBalance (I should change on coin_rpc.rb too) it will break Bitcoin RPC , so it basically need some implemention, there is a gem for monero https://github.com/skyach/peatio-monero and it doesn't work with this version of peatio.