Closed PhearZero closed 2 years ago
Is this completed? @PhearZero (no rush if not as there are numerous other priorities)
Is this completed? @PhearZero (no rush if not as there are numerous other priorities)
@atrefonas It's a project for next year when we adopt algodex/algodex-components
Sounds good to me.
On Wed, Dec 15, 2021 at 8:44 PM Michael J Feher @.***> wrote:
Is this completed? @PhearZero https://github.com/PhearZero (no rush if not as there are numerous other priorities)
It's a project for next year when we adopt algodex/algodex-components https://github.com/algodex/algodex-components
β You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/algodex/algodex-react/issues/178#issuecomment-994888732, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARL6JWYEMPEWIJAF6JLVM2TURCWFJANCNFSM5IK3UVJA .
Branch issue-178-V1-Next_π¨_Component_Driven_Refactor created!
Could not create branch issue-178-V1-Next_π¨_Component_Driven_Refactor
due to: Reference update failed
βΉ Overview
Increase organization and Separation of Concerns in the UI. Remove custom components in favor of MUI where possible. Reduce the reliance on
index.jsx
exports and use "Named Single File Components" (Button.jsx
). This should also include any CSS/Styled-Components and deprecates*.css.jsx
files. You can see styled-components website repository for guidance on structuring Components.π Related Issues
π Goals:
βCurrent Component Layout:
β Future Component Layout:
β Future Index.jsx Exports:
Using index.jsx should be reserved for a collection components, organized by the entity that they pertain to. They can include a default export but should be avoided when possible
We should favor individual imports over index.jsx exports
π Quality Assurance(QA)
QA is handled by Husky, ESLint, Jest, Cypress and Storybook. ESlint catches early errors. Jest is used for any reusable components to provide snapshots and unit tests. Cypress handles end to end testing of the Frontend and Backend and leverages Saucelabs Cypress Connect. Storybook is a critical part of the QA cycle and all composed layout components should have a story with all possible tests for UX/UI designers to validate the implementation prior to merging changes.
π Application Lifecycle: