Open atrefonas opened 2 years ago
PhearZero
commented
2 years ago We should add a table cell for Wallet's Order History to not break existing functionality. If you click on a Wallet's Order it currently navigates to that Asset.
The Asset Trade History should work without any additional UI/UX components and already contains GroupID in the responses
atrefonas
commented
2 years ago We should add a table cell for Wallet's Order History to not break existing functionality. If you click on a Wallet's Order it currently navigates to that Asset.
The Asset Trade History should work without any additional UI/UX components and already contains GroupID in the responses
Ideally clicking on the wallet order history should open up algoexplorer for the transaction group id I think.
PhearZero
commented
2 years ago We should add a table cell for Wallet's Order History to not break existing functionality. If you click on a Wallet's Order it currently navigates to that Asset. The Asset Trade History should work without any additional UI/UX components and already contains GroupID in the responses
Ideally clicking on the wallet order history should open up algoexplorer for the transaction group id I think.
Maybe a miscommunication or I just don't understand the comment. We are going to add the functionality but it needs to be in a custom button or new column. We already had a feature request to add the link to navigate to the asset when it is clicked, we would be reverting user requested features. If we had any click on the row navigate to another page it would be a much worse user experience.
It's not uncommon to have action columns like the cancel order column already in place for a wallet's open orders tables. It would be unintuitive when a user is clicking around and randomly navigates to another site entirely. It should be similar to AssetInfo Explorer Link just in the table with a clear Call To Action for the user
atrefonas
commented
2 years ago Yea that’s true. Maybe it would need to be a new column or some icon that opens up the Algoexplorer transactions. Rather than the entire row navigating there.
On Thu, Jan 20, 2022 at 10:37 PM Michael J Feher @.***> wrote:
We should add a table cell for Wallet's Order History to not break existing functionality. If you click on a Wallet's Order it currently navigates to that Asset. The Asset Trade History should work without any additional UI/UX components and already contains GroupID in the responses
Ideally clicking on the wallet order history should open up algoexplorer for the transaction group id I think.
Maybe a miscommunication or I just don't understand the comment. We are going to add the functionality but it needs to be in a custom button or new column. We already had a feature request to add the link to navigate to the asset when it is clicked, we would be reverting user requested features. If we had any click on the row navigate to another page it would be a much worse user experience.
It's not uncommon to have action columns like the cancel order column already in place for a wallet's open orders tables. It would be unintuitive when a user is clicking around and randomly navigates to another site entirely. It should be similar to AssetInfo Explorer Link just in the table with a clear Call To Action for the user
— Reply to this email directly, view it on GitHub https://github.com/algodex/algodex-react/issues/200#issuecomment-1018137961, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARL6JWZIOL66CUDQSETKAJ3UXDIG3ANCNFSM5JKFDVSA . You are receiving this because you authored the thread.Message ID: @.***>
ℹ Overview
Add a Table Column and Custom Explorer Link Cell to the Wallet 's Order History Table. Also, add a explorer link to an Asset's Trade History Tables Row. They both should open a new browser tab to the Algoexplorer group of transactions.
group_idfrom the API🔍 Information:
const ExplorerLinkCell = ({ value }) => <Icon type="SomeIcon"><a href={value} target="_blank"/></Icon>⚙ Details
Clicking on any of these in the red boxes
For example should open this link in a new tab: https://testnet.algoexplorer.io/tx/group/g9rrWrJWJHWFr6rwH%2FDGnUb%2FiEHQ1xwJMP%2FnFQWxePs%3D