search

algodex / algodex-sdk

Client-side JavaScript SDK for Algodex as an npm package
https://docs-sdk.algodex.com
Mozilla Public License 2.0
8 stars 2 forks source link

🐞 Price fix for taker order execution #316

Closed ericsharma closed 1 year ago

ericsharma commented 1 year ago

ℹ Overview

Temporarily bump the unformatted price of taker orders because taker execution does an initial filtering of potential orders based on the unformatted price and the unformatted price of bot orders could be of a higher precision than that of unformatted prices placed on the front end.

📝 Related Issues

315

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
algodex-sdk ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 2:35PM (UTC)
ericsharma commented 1 year ago

Looks good. Assuming you tested this as well?

Yeah I tested it so say you were executing a taker buy order of 953.5202 algo, for the taker execution section we will increase the price to 953.5202009999999 that way we don't miss any potential trades when filtering the orderbook. If there is any remainder after taker execution we set the price back to the original, user inputted price of 953.5202 algo The interesting thing about this is that the compile step normalizes the variations in the unformatted price so when you look at the actual orderbookentry and compare the n and d they are the same. We just happen to do some preliminary filtering with the unformatted price before normalizing with compile.