search

algolia / algoliasearch-client-android

Algolia Search API Client for Android
MIT License
99 stars 29 forks source link

MirroredIndex:getObjectAsync is crashing #564

Open robertmogos opened 5 years ago

robertmogos commented 5 years ago

Do you want to request a feature or report a bug? Bug

Bug: What is the current behavior?

public Request getObjectAsync(final @NonNull String objectID, final @Nullable Collection<String> attributesToRetrieve, @Nullable RequestOptions requestOptions, @NonNull CompletionHandler completionHandler

In the MirroredIndex:getObjectAsync we allow attributesToRetrieve to be nullable. If the index is mirrored we return a new OnlineOfflineGetObjectRequest. In the constructor we are creating a new ArrayList from attributesToRetrieve. When the later is null, it will result in a crash.

Bug: What is the expected behavior?

Not crashing would be pretty sweet.

Bug: Which versions?

Latest

Bug: How to reproduce ?

 mirroredIndex.getObjectAsync("my-awesome-id", new CompletionHandler() {
            @Override
            public void requestCompleted(JSONObject jsonObject, AlgoliaException e) {
                //...
            }
});