search

algolia / algoliasearch-client-java

⚡️ A fully-featured and blazing-fast Java API client to interact with Algolia.
https://www.algolia.com/doc/api-client/getting-started/install/java/
MIT License
46 stars 33 forks source link

Memory optimization of ZoneRules usage. #684

Closed lucaspouzac closed 4 years ago

lucaspouzac commented 4 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue no
Need Doc update no

Describe your change

Just optimize retrieve ZoneRules for ZoneOffset.UTC

What problem is this fixing?

Significant memory consumption observed during a load test.

algolia_memory_pressure

Ant-hem commented 4 years ago

Hi @lucaspouzac ! Thanks for the contribution.

Could you please run mvn com.coveo:fmt-maven-plugin:format? The formatting makes the CI crash.

aseure commented 4 years ago

I've ran the tests manually against a working cluster (our default cluster is having issues today) and I confirm that all the tests are passing.

Thanks for the contribution @lucaspouzac!

Waiting for the reformat amend that @Ant-hem suggested and then LGTM 👍

lucaspouzac commented 4 years ago

I update, but CI is already KO.

lucaspouzac commented 4 years ago

When CI will be OK, could you release a 3.8.1 version ?

aseure commented 4 years ago

Everything's green on my end after re-running the tests locally.