search

algolia / algoliasearch-client-java

⚡️ A fully-featured and blazing-fast Java API client to interact with Algolia.
https://www.algolia.com/doc/api-client/getting-started/install/java/
MIT License
46 stars 33 forks source link

fix(build): make the algoliasearch-apache-uber JAR compliant with OSGi #709

Closed aseure closed 4 years ago

aseure commented 4 years ago

After a few tries, this version is confirmed to work on our AEM environment as well as the customer's environment.

I would have loved to find a cleaner way to expose the relocated nio.client but this seems really difficult since

  1. maven-bundle-plugin runs before the maven-shade-plugin which relocates several org.apache.http packages
  2. @BenoitPerrot' suggestion to change the order of the plugin by changing their <phase> lead to another suite of issues, I'm not saying this is impossible, but at this point the current solution is the more efficient in term on invested time.
BenoitPerrot commented 4 years ago

Actually I don't think this change is specific to AEM; it would be required on any OSGi engine. Let's be more clear about it in the commit title!

aseure commented 4 years ago

Actually I don't think this change is specific to AEM; it would be required on any OSGi engine. Let's be more clear about it in the commit title!

Good catch indeed @BenoitPerrot, thanks for noticing. I've amended the commit message as well.