search

algolia / algoliasearch-client-javascript

⚡️ A fully-featured and blazing-fast JavaScript API client to interact with Algolia.
https://www.algolia.com/doc/api-client/javascript/getting-started/
MIT License
1.33k stars 222 forks source link

fix: add types to manifest exports #1541

Closed Zach-Jaensch closed 3 months ago

Zach-Jaensch commented 3 months ago

Apologies in advance if I have missed something.

fixes: #1540

Type exports were missing from the manifest. I have verified locally that the types now work, however have noticed that the inferred return type from algoliasearch is still failing, possibly due to the use of *.ts files from the other packages. This may require changes to the build config.

I can create a minimum repo to help with testing in the morning if need be.

shortcuts commented 3 months ago

Hey, thanks for opening the PR, I was actually answering your issue!

The changes look good but needs to be ported to https://github.com/algolia/api-clients-automation, more specifically in https://github.com/algolia/api-clients-automation/blob/main/templates/javascript/clients/package.mustache, as those API clients are generated.

Would you like me to move your PR there, or do you have time to do it? thanks!

Zach-Jaensch commented 3 months ago

Hey, ah I figured I would have missed something. I'm Australian based so about to call it for the night. Happy to re-do it in the morning, also just as happy for you to close this and port it over. I'll take a look when I start up in the morning. Thanks!

shortcuts commented 3 months ago

Hey, ah I figured I would have missed something. I'm Australian based so about to call it for the night. Happy to re-do it in the morning, also just as happy for you to close this and port it over. I'll take a look when I start up in the morning. Thanks!

Don't worry, enjoy a relaxing night I'll port the changes :D Thanks again for contributing