feat: bootstrap new testing strategy

algolia / algoliasearch-client-php

⚡️ A fully-featured and blazing-fast PHP API client to interact with Algolia.

https://www.algolia.com/doc/api-client/php/getting-started/

MIT License

671 stars 116 forks source link

feat: bootstrap new testing strategy #683

Closed DevinCodes closed 7 months ago

DevinCodes commented 3 years ago

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no

Describe your change

This bootstraps a new way to test our API client, where (for PRs) we test the formed requests instead of calling Algolia directly.

VladislavFitz commented 3 years ago

Looks really good 👍 I didn't get how the loadRequestsForMethod method works. Where can I find its implementation?

TomKlotzPro commented 3 years ago

It's awesome! Really nice work !

Just asking about the YAML request files :

Should we all have the YAML files in our repository or could we have a centralised part in the CTS were we just took the files?

DevinCodes commented 3 years ago

Should we all have the YAML files in our repository or could we have a centralised part in the CTS were we just took the files?

@TomKlotzPro I was thinking to have this in a centralized repository, and automatically open PRs on all the clients when we push changes to the production branch. Like that the specs are shared, and we don't rely on git submodules to have it shared.

damcou commented 3 years ago

Really nice ! 🚀