search

algolia / algoliasearch-client-php

⚡️ A fully-featured and blazing-fast PHP API client to interact with Algolia.
https://www.algolia.com/doc/api-client/php/getting-started/
MIT License
671 stars 116 forks source link

fix: psr log #696

Closed damcou closed 2 years ago

damcou commented 2 years ago
Q A
Bug fix? yes
Related Issue Fix #692
greg0ire commented 2 years ago

This could be fixed by using a trait in the DebugLogger, similar to this: https://github.com/doctrine/dbal/blob/2.13.x/lib/Doctrine/DBAL/Driver/PDOQueryImplementation.php

greg0ire commented 2 years ago

Actually since the class is final, you may just add a :void return type declaration, it will not be a BC-break, and should make the signature compatible with both versions.