algolia / algoliasearch-client-php

⚡️ A fully-featured and blazing-fast PHP API client to interact with Algolia.
https://www.algolia.com/doc/api-client/php/getting-started/
MIT License
671 stars 116 forks source link

Fixes deprecation alert when using symfony/error-handler #703

Closed MarcBrillault closed 2 years ago

MarcBrillault commented 2 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Related Issue Fix #701
Need Doc update no

Describe your change

Added PHPDoc @returns to some methods to prevent a deprecation alert when using symfony/error-handler

greg0ire commented 2 years ago

Ping @damcou can we get this merged and released? :pray:

damcou commented 2 years ago

Hello @greg0ire , Sorry for the delay, I just merged it. Regarding the release, we'll try to take a look at it at the beginning of this month (june), it's on our to-do list.

Thanks for understanding.

greg0ire commented 2 years ago

Thanks, looking forward to it!

greg0ire commented 2 years ago

ping @damcou :pray:

damcou commented 2 years ago

Hello @greg0ire I'm very sorry, I know we're late on this, but we had some other pressing priorities on some other topics in June :( We will do our best to release this week or next week, sorry again !

damcou commented 2 years ago

Hello @greg0ire

The v3.3.0 has just been released, sorry again for the delay :( .

greg0ire commented 2 years ago

Thanks a lot!