search

algolia / algoliasearch-client-php

⚡️ A fully-featured and blazing-fast PHP API client to interact with Algolia.
https://www.algolia.com/doc/api-client/php/getting-started/
MIT License
671 stars 116 forks source link

Add phpdoc regarding return types #710

Closed greg0ire closed 1 year ago

greg0ire commented 2 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Need Doc update no

Describe your change

This is similar to #703 . The change adds phpdoc comments to document the return types of the response class.

What problem is this fixing?

This should make some deprecations messages about the possibility the parent class adds return type declarations in the future disappear.

greg0ire commented 2 years ago

@damcou please review

greg0ire commented 1 year ago

@damcou let's merge and release?

damcou commented 1 year ago

Hello @greg0ire , this is done. Again sorry the delay.

greg0ire commented 1 year ago

No worries, and thanks for merging!