search

algolia / algoliasearch-client-python

⚡️ A fully-featured and blazing-fast Python API client to interact with Algolia.
https://www.algolia.com/doc/api-client/getting-started/install/python/?language=python
MIT License
196 stars 67 forks source link

requests[security] and the C tool chain #333

Closed ewdurbin closed 6 years ago

ewdurbin commented 6 years ago

Hello!

Algolia has been super fun to learn and start working with.

I had one minor concern regarding the pinned dependency on requests[security].

We're using the client with AWS Lambda which makes C Dependencies a major pain in the butt.

Specifying the security extras on your package is an excellent idea, as it ensures that folks with older/out-of-date Python installations get a nice high quality TLS connection to your servers.

For folks running Modern Pythons™️ this is no longer necessary.

And unfortunately for folks running in AWS Lambda or other environments that make deploying pure python modules/dependencies easy, it's just a pain in the butt to add PyOpenSSL, cffi, and cyptography.

You could consider using PEP 508 Environment Markers to specify requests[security] for ancient Pythons, while letting folks running the good stuff skate away into the server less sunset :)

LeoErcolanelli commented 6 years ago

Hi there,

Thanks for the feedback! As it turns out, requests itself is not compatible with the python versions that would have needed the flair, I just removed it.

The PR is here https://github.com/algolia/algoliasearch-client-python/pull/335 I am just waiting for the reviewers to mark it as valid, and I will release a new version.

Thanks again!

julienbourdeau commented 6 years ago

I believe this was fixed by v1.15.3.