Closed paul-finary closed 1 year ago
Hi @shortcuts , I opened this PR because the other one (https://github.com/algolia/algoliasearch-client-python/pull/551) is stale for 3 weeks now. However the tests are failing on circleci even though they're all passing locally. Do you have any idea ?
Hi @shortcuts, Sorry to insist, but did you have a look at this PR ?
Hi again,
Can someone look at this PR ?
hey, checking right now for the CI! thanks for the contribution :)
looks great! small comment
Hi, I fixed both comments :)
Hi, there' still issues with the pipelines even thought the tests are running locally, do you have an idea on how to solve it ?
hey @paul-finary, fixed the CI so it should now properly run and report errors, let me know if you still have time to work on that
fixed some more again, should be more reliable now, still some flaky ones but there seems to be errors related to yield inside async fns
Describe your change
This PR removes support for python 2.7, adds support for python 3.11 and tests the project against 3.9, 3.10, and 3.11:
yield from
withawait
orreturn
statementsWhat problem is this fixing?
Due to a removed syntax in python 3.11, the package was not working.