algolia / algoliasearch-client-python

⚡️ A fully-featured and blazing-fast Python API client to interact with Algolia.
https://www.algolia.com/doc/api-client/getting-started/install/python/?language=python
MIT License
196 stars 67 forks source link

feat: add support for Python 3.9, 3.10 and 3.11 #553

Closed paul-finary closed 1 year ago

paul-finary commented 1 year ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #549, Fix #551
Need Doc update yes

Describe your change

This PR removes support for python 2.7, adds support for python 3.11 and tests the project against 3.9, 3.10, and 3.11:

What problem is this fixing?

Due to a removed syntax in python 3.11, the package was not working.

paul-finary commented 1 year ago

Hi @shortcuts , I opened this PR because the other one (https://github.com/algolia/algoliasearch-client-python/pull/551) is stale for 3 weeks now. However the tests are failing on circleci even though they're all passing locally. Do you have any idea ?

paul-finary commented 1 year ago

Hi @shortcuts, Sorry to insist, but did you have a look at this PR ?

paul-finary commented 1 year ago

Hi again,

Can someone look at this PR ?

shortcuts commented 1 year ago

hey, checking right now for the CI! thanks for the contribution :)

paul-finary commented 1 year ago

looks great! small comment

Hi, I fixed both comments :)

paul-finary commented 1 year ago

Hi, there' still issues with the pipelines even thought the tests are running locally, do you have an idea on how to solve it ?

shortcuts commented 1 year ago

hey @paul-finary, fixed the CI so it should now properly run and report errors, let me know if you still have time to work on that

shortcuts commented 1 year ago

fixed some more again, should be more reliable now, still some flaky ones but there seems to be errors related to yield inside async fns