feat(browse): Implement browse POST request

algolia / algoliasearch-client-scala

⚡️ A fully-featured and blazing-fast Scala API client to interact with Algolia.

https://www.algolia.com/doc/api-client/getting-started/install/scala/

MIT License

26 stars 29 forks source link

feat(browse): Implement browse POST request #621

Closed yawen-QvQ closed 3 years ago

yawen-QvQ commented 3 years ago

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Need Doc update	no

Describe your change Replace the existing browse GET request with browse POST. When the query to too long, GET request returns 414.

benwaffle commented 3 years ago

@Aallam can you review? Also, what do we think about just replacing the existing browse method to use POST instead of GET? Do you expect that to break anything?

aallam commented 3 years ago

Hi @benwaffle and @yawen-QvQ, thank you for your PR! I don't expect this won't break anything, if we look at Java client implementation, it uses POST and it works as expected.

aallam commented 3 years ago

I've created a fork of this PR (#622) to run the CI.