search

algolia / algoliasearch-client-scala

⚡️ A fully-featured and blazing-fast Scala API client to interact with Algolia.
https://www.algolia.com/doc/api-client/getting-started/install/scala/
MIT License
26 stars 29 forks source link

similarQuery not accounted for in param string #654

Closed shawncruz closed 2 years ago

shawncruz commented 2 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #...
Need Doc update maybe

Describe your change

Add similarQuery to params sent to Algolia.

What problem is this fixing?

While similarQuery is exposed by the Query class type, it isn't used when it comes time to build the params string. The result is that similarQuery isn't sent to Algolia during execution.

shawncruz commented 2 years ago

@Aallam 👋🏻 A review would on this would be much appreciated. The current failing tests seem to be unrelated to the changes introduced by this PR.

aallam commented 2 years ago

I've run the tests, and it works as expected! thank you @shawncruz for your contribution :)