search

algolia / algoliasearch-client-swift

⚡️ A fully-featured and blazing-fast Swift API client to interact with Algolia.
MIT License
205 stars 65 forks source link

fix(search): disjunctive faceting helper #866

Closed Fluf22 closed 1 month ago

Fluf22 commented 2 months ago

Summary

Solves DI-2708

There was a discrepancy between v7 and v8 of the client where the helper began using the filters property instead of the facetFilters property, as recommended by the official Algolia documentation, but not taking into account that users may already be using the property. We needed to make sure existing filters were preserved.

Result

The filters property is no longer overwritten.

Fluf22 commented 2 months ago

Hey @morgan-backmarket 👋🏻 Just chiming in to ask if you had time to run some tests on your side? No pressure of course!

morgan-backmarket commented 2 months ago

Hey @morgan-backmarket 👋🏻 Just chiming in to ask if you had time to run some tests on your side? No pressure of course!

Hey @Fluf22,

Perfect timing—I was just about to reach out to you. The initial group of internal testers has completed their first round of testing on the version I deployed in-house. They didn’t notice any differences between this new SDK version and the one currently in production, which is excellent news.

Next Monday, I’ll open the testing to the entire iOS chapter and ask them to perform the same tests. I’ll be out of the office until mid-September. Would it be alright to wait for my return to review the results of the iOS Chapter tests?

Thank you!

Fluf22 commented 2 months ago

That's perfect, thank you very much! I'm gonna try working on the Kotlin one in parallel 😊