Support auto-indexing for proxy models

algolia / algoliasearch-django

Seamless integration of Algolia into your Django project.

https://www.algolia.com

MIT License

173 stars 65 forks source link

Support auto-indexing for proxy models #272

Closed browniebroke closed 3 years ago

browniebroke commented 5 years ago

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	TBC
Related Issue	Fix #270
Need Doc update	yes

Describe your change

Better support for auto-indexing with proxy models

What problem is this fixing?

See description in #270.

Work progress

[ ] Write tests for the new feature
[ ] Make sure no existing tests break
[ ] Change code to support the new feature
[ ] Make sure all tests pass
[ ] Update documentation if needed
[ ] Update CHANGELOG.md

tkrugg commented 3 years ago

Hi @browniebroke sorry for the late reply. In the related issue -- #270 -- the plan was to use <model>._meta.concrete_model but I see you're using instead <model>._meta.proxy_for_model. Has there been any complications in using concrete_model ?

browniebroke commented 3 years ago

Waw, old one! I don't remember to be honest, I had some issues testing this locally and since there is (was?) no CI enabled, I pretty much abandoned it.

PS: anyone feel free to close or reuse the work.

tkrugg commented 3 years ago

thanks @browniebroke I'll close for now but i'll keep the issue open