search

algolia / algoliasearch-django

Seamless integration of Algolia into your Django project.
https://www.algolia.com
MIT License
173 stars 65 forks source link

disable indexing decorator not working #296

Closed dbinetti closed 3 years ago

dbinetti commented 4 years ago

Description

The @disable_auto_indexing decorator does not appear to work.

Steps To Reproduce

Use the @disable_auto_indexing on a function.

Expect: No reindexing

Get: Indexing.

-- This one hurts, because it cost me $100 to reindex fields that didn't need to be indexed...

tkrugg commented 3 years ago

Hi @dbinetti, thanks for reporting this issue and sorry to hear it had cost implications. Are you able to provide a sample of the code you've used it on?

What I can say is that this decorator has a test that isn't failing when tested on python 3.6 and django 3.1: https://travis-ci.org/github/algolia/algoliasearch-django/jobs/748217497

I think it might be that the model you've used it on was not registered, or that the indexing in your specific case was not performed via the post_save receiver. A code sample would definitely help me troubleshoot.

dbinetti commented 3 years ago

Been five months and I've left the project, so I'm afraid I can't help. Closing.