search

algolia / algoliasearch-helper-flutter

⚡️ Building block to create instant-search applications with Flutter
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/flutter/
Other
21 stars 14 forks source link

fix(facet): export facet model #112

Closed Peetee06 closed 7 months ago

Peetee06 commented 8 months ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #...
Need Doc update no

Describe your change

Adds export of facet.dart so the Facet class is visible to the compiler which allows code with Facet type annotation to work.

What problem is this fixing?

The Facet class wasn't exported which resulted in the compiler not finding it when making type annotations. An example of this would be in the Getting started guide in this section for body: StreamBuilder<List<SelectableItem<Facet>>>(. The code there doesn't compile without the export.

Peetee06 commented 7 months ago

@VladislavFitz could you review this, please? Working on a project that needs this fix.

VladislavFitz commented 7 months ago

Hi @Peetee06 , Thank you for this fix, this is definitely an oversight.