feat(HitsSearcher): multi user agent

algolia / algoliasearch-helper-flutter

⚡️ Building block to create instant-search applications with Flutter

Other

21 stars 14 forks source link

Closed aallam closed 3 months ago

aallam commented 1 year ago

[x] Dart Helper: add extraUserAgents param.
[x] Flutter Helper
- [x] Add HitsSearcher delegation
- [x] Hide Dart Helper's HitsSearcher and expose a delegating implementation instead.
[x] Extract version/user-agent to constants.dart

Closes FX-2014

seafoox commented 1 year ago

Leaning on @VladislavFitz to review your PR.

In the meantime,

can you please explain in which case algolia-helpers-dart get sent and in which case algolia-helpers-flutter get sent?
in regards of the version number, they share the same one, right?

aallam commented 1 year ago

Hi @seafoox,

can you please explain in which case algolia-helpers-dart get sent and in which case algolia-helpers-flutter get sent?

Dart Helper -> algolia-helpers-dart is sent
Flutter Helper -> algolia-helpers-flutter is sent (plus dart user agent, since it depends on it)

in regards of the version number, they share the same one, right?

For now they are in sync yes, but this can change over time.