algolia / algoliasearch-helper-js

Helper for implementing advanced search features with Algolia
https://instantsearchjs.netlify.app/algoliasearch-helper-js/
MIT License
174 stars 46 forks source link

feat(disjunctiveFacetParams): reduce payload size #912

Closed Jerska closed 2 years ago

Jerska commented 2 years ago

This PR reduces the amount of params sent for each disjunctive facet request. It also reduces hitsPerPage from 1 to 0, allowing us to remove the attributes* parameters at the same time.

This reduces:

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02d7a9e7794f91297bd521543c7d39844dc9a351:

Sandbox Source
javascript-helper-app Configuration
InstantSearch.js Configuration
Haroenv commented 2 years ago

this looks great! I've tried it out in a sandbox here and everything works as expected https://codesandbox.io/s/javascript-helper-app-forked-jyn60w?file=/src/app.js

Could you update the tests too?

Jerska commented 2 years ago

Yes I'm on it, but I'm currently struggling with the node-sass version not being compatible with node 16 ^^" Thanks for trying on a sandbox !

sarahdayan commented 2 years ago

We can replace node-sass with dart-sass in another PR since the former is deprecated.