fix ruby 3.0 default splat behavior

algolia / algoliasearch-rails

AlgoliaSearch integration to your favorite ORM

MIT License

410 stars 118 forks source link

fix ruby 3.0 default splat behavior #401

Closed bvogel closed 3 years ago

bvogel commented 3 years ago

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Related Issue	Fix #...
Need Doc update	no

Describe your change

Ruby 3.0 will not splat arguments on default

What problem is this fixing?

wrong number of arguments (given 2, expected 0..1)

bvogel commented 3 years ago

@chloelbn @redox as I can't seem to see what is failing, could you point me in the right direction to get the checks to pass?

(I did run rspec locally on ruby 2.7.3 and 3.0.1 and both pass, older ruby versions I don't have readily available)

bvogel commented 3 years ago

@chloelbn @redox any chance to get someone look at this and https://github.com/algolia/algoliasearch-rails/pull/400 - we would really need that to be able to upgrade to ruby 3

redox commented 3 years ago

@DevinCodes are you able to take a look?

bvogel commented 3 years ago

@DevinCodes please disregard this PR, as I broke stuff when force pushing to my branch. the correct PR for v1 is on #402, the one for v2/master still is valid on #400

DevinCodes commented 3 years ago

I’ll take a look on Monday, I’m busy moving atm so I won’t have time until then!

DevinCodes commented 3 years ago

Closing this PR as per your message. Your other PRs have been merged, we'll release the changes later today! Thank you for the contributions! 🎉