algolia / algoliasearch-zendesk

Integrate Algolia within your Zendesk Help Center in minutes.
https://community.algolia.com/zendesk
Other
21 stars 12 forks source link

feat(hits): introduce hits fullpath in search results #183

Closed jerrytohvan closed 11 months ago

jerrytohvan commented 1 year ago

Creating PR for proposal added here: https://github.com/algolia/algoliasearch-zendesk/issues/182#issue-1971967937

jerrytohvan commented 1 year ago

Head's up that I need help and guidance to check if this is the best implementation. I was also encountering blockers from running local environment to test this properly.

Jerska commented 1 year ago

This looks like a great addtion! Can you share which blockers you faced on the local setup?

jerrytohvan commented 1 year ago
image

@Jerska , i received the above error when running npm start and didnt manage to get clean npm install. Running node on version 10.24.1 currently. Anything that I might have missed?

jerrytohvan commented 12 months ago

Hi @Jerska , following up on this if you are able to assist with pull request? :)

Jerska commented 11 months ago

Sorry for not getting back to you earlier!

I just merged a PR that should make it easier to run locally, I'd recommend you to pull master again & retry npm install && npm run dev (sorry this repo is quite old, and libs that were cutting edge back them are so old today...).

That being said, I can confirm it works:

image

It's a bit heavy in terms of effects for the general library, I have a few changes to recommend that would make them look like so:

image
jerrytohvan commented 11 months ago

Thanks for the review and I've pushed your suggestions @Jerska !

jerrytohvan commented 11 months ago

Thank you team @sbellone @Jerska ! 👏 Are there timeline on next package version being published for usage? :)

Jerska commented 11 months ago

I'll release. :)

Jerska commented 11 months ago

Had to fight the dependencies of all systems, but it's freshly released in 2.32.0! See:

jerrytohvan commented 11 months ago

thank you all!