algolia / angular-instantsearch

⚡️Lightning-fast search for Angular apps, by Algolia
https://algolia.com/doc/deprecated/instantsearch/angular/v4/api-reference/instantsearch/
MIT License
261 stars 73 forks source link

Algolia + instantsearch doesn't work on IE11 #817

Closed asvitlica-vega closed 3 years ago

asvitlica-vega commented 3 years ago

🐛 Bug description

We've been experiencing bugs with instantsearch and Algolia integration in IE11. We checked the docs, tried out the official polyfil.io fix, but the problem persisted.

We get the following errors: Unable to get property 'add' of undefined or null reference Unable to get property 'removeAllListeners' of undefined or null reference

FYI Our app is written in Angular 11

🔍 Bug reproduction

Component initialization: algolia

eunjae-lee commented 3 years ago

Hi @asvitlica-vega I believe this concerns "Angular InstantSearch", so I moved the ticket to this repository. Could you provide us with a minimal reproduction so that we can take a look at your issue? With the information given, it's hard for us to know.

asvitlica-vega commented 3 years ago

@eunjae-lee it is really hard to provide you with a small snippet, but I'll try. Meanwhile, here's the exact line we're receiving an error from: removelisteners

Haroenv commented 3 years ago

It seems like the index widget unmounts either before init was called or after it had already been removed. Are you really seeing this only on IE11? It seems unrelated to the browser

asvitlica-vega commented 3 years ago

It seems like the index widget unmounts either before init was called or after it had already been removed. Are you really seeing this only on IE11? It seems unrelated to the browser

Yes, it only happens on IE11. Library versions we use (maybe they are not compatible):

Haroenv commented 3 years ago

Yes, that's true, InstantSearch.js should be <4, so InstantSearch@3.7.0

asvitlica-vega commented 3 years ago

Changing the version didn't work. We're dropping the feature for IE11.

tkrugg commented 3 years ago

Alright, I'll close this issue then. Feel free to reopen if any change on your side.