algolia / angular-instantsearch

⚡️Lightning-fast search for Angular apps, by Algolia
https://algolia.com/doc/deprecated/instantsearch/angular/v4/api-reference/instantsearch/
MIT License
261 stars 73 forks source link

qs, hogan.js, algoliasearch-helper. CommonJS or AMD dependencies can cause optimization bailouts. #894

Closed thiboot closed 2 years ago

thiboot commented 2 years ago

Need to update or find alternatives for these 3 CommonJS or AMD dependencies.

`Warning: project/node_modules/instantsearch.js/es/lib/routers/history.js depends on 'qs'. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: project/node_modules/instantsearch.js/es/lib/utils/renderTemplate.js depends on 'hogan.js'. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: project/node_modules/instantsearch.js/es/widgets/index/index.js depends on 'algoliasearch-helper'. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies`

Haroenv commented 2 years ago

Hi @thiboot, thanks for your issue. We have these updates planned for the future, but it requires a significant amount of work. For the mean time, there actually aren't any parts of those libraries that exist, but aren't used. That means that while there are slight possible tree shakings happening, nothing significant would change.

this is a duplicate of #810

As such, and since this is only a warning, not an error, I will close this issue. Thanks!