algolia / angular-instantsearch

⚡️Lightning-fast search for Angular apps, by Algolia
https://algolia.com/doc/deprecated/instantsearch/angular/v4/api-reference/instantsearch/
MIT License
261 stars 73 forks source link

Compilation error: Cannot find module 'places.js' or its corresponding type declarations. #988

Open kisamoto opened 1 year ago

kisamoto commented 1 year ago

Describe the bug 🐛

Receiving a compilation error when trying to use the latest version of angular-instantsearch.

Expected behavior 💭

Successful compilation.

Environment:

Additional context

fourthofaugust commented 1 year ago

@kisamoto I was able to fix this compilation error by installing npm i -D @types/places & npm i places.js.

kisamoto commented 1 year ago

Can confirm that fixes it but should either:

  1. be in the docs;
  2. or have the dependency removed (places.js is in the public archive)
fourthofaugust commented 1 year ago

@kisamoto Yeah that's true. Maybe one of the maintainers should document it.

mazenaboelanin commented 1 year ago

@fourthofaugust @kisamoto it’s wasn’t resolved when using yarn add @types/places

Haroenv commented 1 year ago

Can someone make a reproduction of this? When I'm trying this in the examples, places doesn't need to be loaded.

mazenaboelanin commented 1 year ago

@Haroenv solved by running yarn add @types/places && yarn add places.js