search

algolia / cli

🔍 Algolia’s official CLI devtool
https://www.algolia.com/doc/tools/cli
MIT License
103 stars 26 forks source link

feat(cli): also delete replica indices #127

Closed kai687 closed 1 year ago

kai687 commented 1 year ago

This PR adds a new boolean option to the algolia indices delete command: --includeReplicas. If it's true, the command will look for any replicas of an index and deletes them with the primary index. No more dangling indices because of replicas.

DEX-784

kai687 commented 1 year ago

@clemfromspace got stuck writing the test (or rather the mock) for the new option. Don't know what I'm doing wrong.

clemfromspace commented 1 year ago

@kai687 On it!

clemfromspace commented 1 year ago

@kai687 The tests should pass now, there was missing matching stubs. Makes me think the current stubs system is not explicit enough when there is missing stubs / unmatched stubs.

kai687 commented 1 year ago

Thank you so much with your help on the tests.