profile/list: show errors in table listing instead of failing

dhowden commented 4 months ago

Without annotation the error is not helpful when you have multiple profiles.

Note: this also uses the AdminAPIKey, which might need another change to amend.

dhowden commented 4 months ago

FYI @helenamariano this from our conversation.

clemfromspace commented 4 months ago

Thanks for the PR @dhowden 👍

What do you think about gracefully failing, like displaying the error for the profile in the NB OF INDICES column instead? So we can, at the same time:

See all profiles for which the API credentials are correct (just display the number of indices)
See all profiles for which the API credentials are not correct (wrong AppID and/or APIKey)
See all profiles for which we are missing the listIndices ACL (? (APIKey without listIndices ACL))

I'm happy to take over the PR if you don't have the time, let me know :)

dhowden commented 4 months ago

Hey @clemfromspace.

No worries, I've updated the change to put the error in the table as suggested. Happy for you to take it from here to get it over the line!

algolia / cli

profile/list: show errors in table listing instead of failing #145