algolia / cli

🔍 Algolia’s official CLI devtool
https://www.algolia.com/doc/tools/cli
MIT License
102 stars 26 forks source link

New "delete" actions still need to be registered via cmd.AddCommand(...) #28

Closed khalidelassaad closed 2 years ago

khalidelassaad commented 2 years ago

https://github.com/algolia/cli/blob/edc35d028a3dac4aebe93cd6d79839d5c76df4fb/pkg/cmd/objects/objects.go#L18 https://github.com/algolia/cli/blob/edc35d028a3dac4aebe93cd6d79839d5c76df4fb/pkg/cmd/rules/rules.go#L19 https://github.com/algolia/cli/blob/edc35d028a3dac4aebe93cd6d79839d5c76df4fb/pkg/cmd/synonyms/synonyms.go#L19

For the "objects/synonyms/rules delete" PR, you forgot to call cmd.AddCommand() in the three files linked above, so the commands cannot be run!