algolia / color-extractor

Extract the dominant color(s) of your fashion articles!
https://algolia.com
Other
279 stars 69 forks source link

opencv example in README leads to incorrect color identification with default settings #6

Open rrtaylor opened 6 years ago

rrtaylor commented 6 years ago

In the README example, an image file is opened using opencv, which will open the file in BGR. However, the color_names.npz dataset that comes with the repo is stored as RGB. Therefore if you use the example verbatim, you will get incorrect color identifications. Since from_file.py uses skimage.io instead of opencv, the only corrections needed are on the README, which are:

ankusharya commented 6 years ago

Is this issue fixed?