search

algolia / docsearch-scraper

DocSearch - Scraper
https://docsearch.algolia.com/
Other
308 stars 107 forks source link

upgrade algoliasearch python client from 1.x to 2.x #544

Closed shortcuts closed 3 years ago

shortcuts commented 3 years ago

We were using the python client 1.13, upgrading it to latest stable (2.4.0) allow us to use the copy_rules method, which helps users that run on their own as they won't have to re-write their rules or use replicas.

Tested on: generating - running - deploying ~20 configs

robertmogos commented 3 years ago

The CI is failing, address the issues please

shortcuts commented 3 years ago

The CI is failing, address the issues please

@robertmogos Fixed in https://github.com/algolia/docsearch-scraper/pull/544/commits/73f6057207c299d3371414b66e688343aff32cde

shortcuts commented 3 years ago

Are these all of the methods that need to be replace? Isn't there any other place where we use the 1.X client ?

There was no other imports of algoliasearch, and I've checked all the method names. I'll run a few more configs/take a deeper dive just to be sure