search

algolia / docsearch

:blue_book: The easiest way to add search to your documentation.
https://docsearch.algolia.com
MIT License
3.92k stars 381 forks source link

Pressing enter when searching prevents results from being displayed #1639

Open ascott18 opened 1 year ago

ascott18 commented 1 year ago

Description

If a query is typed out and the Enter key is pressed, the UI reports that the query has no results despite the fact that the AJAX request responded with plenty of results.

https://user-images.githubusercontent.com/5017521/198735876-6d6013d1-5a10-45e9-bfe2-d500f67f8fe7.mp4

Steps to reproduce

  1. Open the search input
  2. Search for something, typing in the query rapidly and pressing enter when done typing.
  3. See the message that there are no results, despite there actually being results that would have been shown had Enter not been pressed after typing.

Live reproduction:

Any site that uses docsearch. E.g. https://docsearch.algolia.com/. To reproduce you may need to enable throttling of network requests in developer tools if searches are completing before you can manage to press enter.

Expected behavior

Pressing Enter triggers the search immediately (same as waiting a short time after stopping typing) but doesn't otherwise break the displaying of results.

Environment

randombeeper commented 1 month ago

@ascott18 I'm just now going through open issues, sorry for the long long delay.

If network traffic is throttled down, the behavior now seems to be a little different. I've seen that sometimes the model just goes away, other times a page is shown that doesn't even match my search. So there is definitely something that could be done here, while not quite exactly what was described initially, there is still some sketchy behavior. Because of that, I'm going to keep it open.