algolia / faux-jax

NO MORE MAINTAINED: Intercept and respond to requests in the browser (AJAX) and Node.js (http(s) module)
MIT License
95 stars 9 forks source link

Node 0.12.7 - Cannot read property 'emit' of null #15

Closed nhunzaker closed 8 years ago

nhunzaker commented 8 years ago

I'm testing against multiple versions of node for a project and node 0.12.7 fails for the following reason:

TypeError: Cannot read property 'emit' of null

Looks like this occurs in FakeRequest::respond around like 189:

  function end() {
    res.end();
    res.socket.emit('end');
  }

I'm happy to dig into this and resolve the issue - but do you have any immediate thoughts?

vvo commented 8 years ago

I think I did a recent commit to fix that

vvo commented 8 years ago

Have a look at master, may need to release though

nhunzaker commented 8 years ago

Ah, yep! Any idea on a timeframe for a release?

vvo commented 8 years ago

In a couple of hours

nhunzaker commented 8 years ago

Cool. Pulling straight from Github works great for me until then. Thank you!

vvo commented 8 years ago

released 5.0.0

nhunzaker commented 8 years ago

Thanks!