algolia / faux-jax

NO MORE MAINTAINED: Intercept and respond to requests in the browser (AJAX) and Node.js (http(s) module)
MIT License
95 stars 9 forks source link

Use shields.io badge for npm-version #9

Closed SimenB closed 9 years ago

SimenB commented 9 years ago

For consistency. Also, the current image is just weird :laughing:

vvo commented 9 years ago

@SimenB I chose the current badge because it's SHINY :)

SimenB commented 9 years ago

Not sure how this constitutes shiny, but sure :laughing:

image

Btw, any idea when the full (aka non-beta) version 4 of this lib is out? I used it to replace Sinon at work (and it works great thanks!), but having the word beta made me go for version 3 instead. I prefer the event driven nature of version 4 :smile:

vvo commented 9 years ago

I guess we can release now and fix two bugs, it had beta for too long while it works really great now: event driven + nodejs support. still some planned work but it works.

It will also fixes the version badge :). I use only this version badge, really about preferences, no big deal.

vvo commented 9 years ago

done

vvo commented 9 years ago

2015-05-24-225057_734x102_scrot

vvo commented 9 years ago

compared to 2015-05-24-225133_766x110_scrot

SimenB commented 9 years ago

@vvo Awesome, thanks.

vvo commented 9 years ago

@SimenB where do you use it?

SimenB commented 9 years ago

At work. Closed source project, so I can't show it. :cry:

We had huge problems making sinon work with webpack, and with sinon spending aaaages releasing version 2 with proper CJS support, I found this alternative. Combined with Lolex, I was able to drop the sinon dep. As we use Jasmine, we already had spies and assertions anyway, much cleaner having network-mocking in its own module :smile:

SimenB commented 9 years ago

@vvo regarding the badge, I didn't notice the sup wrapping... I "fixed" it as I got curious :laughing:

image

But if you prefer the current version, that's of course fine :smile:

I'll give the event-driven way a go at work in a couple of weeks. Looking forward to it, seems really clean.

SimenB commented 9 years ago

@vvo http://vb.teelaun.ch/ seems to be dead, might want to merge this :smile:

SimenB commented 8 years ago

@vvo image

vvo commented 8 years ago

Can you resubmit? :)

SimenB commented 8 years ago

Just reopen this one

SimenB commented 8 years ago

oh never mind, I seem to have deleted the branch

SimenB commented 8 years ago

se #17