algolia / firestore-algolia-search

Apache License 2.0
108 stars 33 forks source link

Prematurely Exiting Full Indexing #189

Closed LucasSwitz closed 6 months ago

LucasSwitz commented 6 months ago

I was using this extension to index a couple hundred thousand documents from Firestore. The indexing job stopped after indexing around 20% of the documents.

Looks like the firestore query returned more documents then was requested by limit(DOCS_PER_INDEXING) 🤷. Because of this, the termination condition triggered and the job ended.

I attached a log showing records.length > DOCS_PER_INDEXING.

I think this can be fixed by just changing the termination condition to records.length < DOCS_PER_INDEXING.

downloaded-logs-20231206-104844.json

LucasSwitz commented 6 months ago

Open pull request: #190

smomin commented 6 months ago

hey @LucasSwitz how many documents are you trying to index? check with Algolia support to make sure your Algolia application is under the right plan.

smomin commented 6 months ago

@LucasSwitz The extension v1.2.0 has been approved. Can you check to see if you are running into the same issues.

smomin commented 6 months ago

I am closing this issue since I have not heard further comments. I will assume the issue is resolved.