Change termination condition for snapshots > DOC_PER_INDEXING

I am publishing a new pagination approach using cursors. The new version (1.2.0) is waiting approval. Wait for this one and hopefully the issue gets resolved.Sent from my iPhoneOn Dec 10, 2023, at 12:35 PM, Lucas Switzer @.***> wrote: @LucasSwitz commented on this pull request.

In functions/src/index.ts:

@@ -219,7 +219,7 @@ export const executeFullIndexOperation = functions.tasks const newSuccessCount = pastSuccessCount + records.length; const newErrorCount = pastErrorCount;

if (snapshot.size === DOCS_PER_INDEXING) {
if (snapshot.size >= DOCS_PER_INDEXING) {

I captured this log where the indexing job receiving 266 documents from Firestore and consequently terminated the indexing job (even when the limit was set to 250). { "textPayload": "[ 'records.length', 266 ]", "insertId": "65702579000b34f8d955faad", "resource": { "type": "cloud_function", "labels": { "project_id": "monster-lab-2a47c", "region": "us-east1", "function_name": "ext-firestore-algolia-search-executeFullIndexOperation" } },

Full gist https://gist.github.com/LucasSwitz/e6ac3682e0036e53e7e1c4bc6841bdda.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

algolia / firestore-algolia-search

Change termination condition for snapshots > DOC_PER_INDEXING #190