search

algolia / frontman

💎 A Ruby-based static website generator
https://rubygems.org/gems/frontman-ssg
MIT License
109 stars 4 forks source link

Add append_content method #25

Closed westonganger closed 4 years ago

westonganger commented 4 years ago

Solves #3

westonganger commented 4 years ago

Ok I will abstract the method and add tests.

westonganger commented 4 years ago

Alright the method abstraction and test are all complete. Please review.

Note: I also used .dup in append_content so that it works with frozen_string_literal: true in tests files or users files

DevinCodes commented 4 years ago

The PR looks good to me, thank you so much for this!!

The CI is failing right now because of Rubocop though, could you please run the rubocop command on your machine and address the issues? Thank you! 💯

westonganger commented 4 years ago

I have addressed a few of the Rubocop concerns however there are a few that need some sort of additional attention.

DevinCodes commented 4 years ago

I have addressed a few of the Rubocop concerns however there are a few that need some sort of additional attention.

I can take care of that if you'd like 🙂

DevinCodes commented 4 years ago

I opened a PR into your branch that should fix the rubocop errors, let me know if it works for you 😄 https://github.com/westonganger/frontman/pull/1

westonganger commented 4 years ago

Works great. Thanks.