Fix setting dev server port

algolia / frontman

💎 A Ruby-based static website generator

https://rubygems.org/gems/frontman-ssg

MIT License

109 stars 4 forks source link

Closed westonganger closed 3 years ago

westonganger commented 4 years ago

Fixes settings ordering issue described in #36

westonganger commented 4 years ago

Apparently today there is new failures for some other rules. Maybe you want to resolve these?

While were at it, I would say lets also disable Style/IfUnlessModifier I think this makes the code worse for the human mind.

DevinCodes commented 3 years ago

Hey @westonganger, hope you're doing good!

I created a PR to your branch (https://github.com/westonganger/frontman/pull/2) to fix the linting errors. Let me know what you think, so we can move this forward and release this!

Thank you again for all your work on Frontman, we really appreciate it 💯

DevinCodes commented 3 years ago

I'll create a PR into your branch to fix the CI today @westonganger 👍

DevinCodes commented 3 years ago

Closed in favor of #42