Update algoliasearch to v4

algolia / gatsby-plugin-algolia

A plugin to push to Algolia based on graphQl queries

https://yarn.pm/gatsby-plugin-algolia

Apache License 2.0

177 stars 45 forks source link

Update algoliasearch to v4 #102

Closed prichey closed 3 years ago

prichey commented 3 years ago

Currently the plugin depends on algoliasearch@^3.24.5, which hasn't been updated in 3 years (since the initial commit, I think?). It'd be great to update to v4 to be consistent with online documentation. I may be able to work on a PR for this, pending other work in progress

Haroenv commented 3 years ago

algoliasearch@3 is no longer recommended, but it's not 3 years old :p version 4 has only been released this February.

I hadn't updated yet because I wasn't sure whether the behaviour of .wait and .waitTask is really the same, but that part of the code is quite different now, so no longer an issue.

browse is also quite different, but that should be a small focused change

prichey commented 3 years ago

Ah, I was just referring to the specific version in the repo. No offense intended! 😊

marcelovicentegc commented 3 years ago

Hi, @prichey! You might want to take a look at this PR: https://github.com/algolia/gatsby-plugin-algolia/pull/135

Haroenv commented 3 years ago

Thanks for your PR @marcelovicentegc !

marcelovicentegc commented 3 years ago

Hey, all! It occurs to me that this issue can be closed since https://github.com/algolia/gatsby-plugin-algolia/pull/135 was merged 😉