algolia / gatsby-plugin-algolia

A plugin to push to Algolia based on graphQl queries
https://yarn.pm/gatsby-plugin-algolia
Apache License 2.0
177 stars 45 forks source link

Fix index settings being wiped #112

Closed epbarger closed 3 years ago

epbarger commented 3 years ago

I manually tested providing settings and not providing settings to make sure the behavior is correct now. I did not test anything around replicas, but I don't see any reason why that would be affected. From what I can tell the replicas feature currently only works if you provide settings in the plugin, because of the reliance on settings.replicaUpdateMode.

urre commented 3 years ago

Hey @Haroenv @epbarger I have this same problem where the facet settings, searchable attributes get wiped when running npm run build. Can I test this PR in some way in my site? Or if you have other suggestions? I tested to remove the settings object in my queries array in my algolia script, but that didn't help

Haroenv commented 3 years ago

if you take the file in your node_modules and edit it to this version, you can test it @urre

urre commented 3 years ago

@Haroenv ah, I'll test

epbarger commented 3 years ago

Sorry I've been swamped with other work and haven't gotten back to this yet. If either one of you is able to take it over the finish line, please feel free!

urre commented 3 years ago

@epbarger it seemed to work, I tested it in my node_modules folder. Is it much left to do to get this published? We are going to publish our search this week, and would be awesome if this fix could be installed from npm

Haroenv commented 3 years ago

Thanks both @urre and @epbarger, I've released this as 0.16.3!

urre commented 3 years ago

Thanks!